I have just started training my priest to tailoring/enchanting and my mage to herbalism/alchemy. I probably want to raid as a holy priest if I ever get to the required level, and I am thinking if I should let the priest take herbalism/alchemy instead if there are useful items that are BoP. I'll probably let my mage to have tailoring/enchanting then as a gear and money maker.

Also, before I forget, are there useful rings from jewelcrafting that are BoE, or are most of them BoP?

Thanks.

Getting herbalism on any char is good since now you get experience for the herbs you harvest, same goes for mining. Most rings made by Jewelcrafting are BoE. I have a needlecraft. I've been sending him and my engineer all the ore I get. Tailoring and Enchanting are good money makers. I got 200 gold the other day with my tailor/enchantor selling things I made with him on the AH, nice thing to he can make a flying carpet.

If you get herbalism/mining on your main then you save a lot of money because you don't have to spend loads on flying for any non-gatherer alts. If you want to get money from professions I would go with alchemy because the transmutes can earn a lot every day and it only takes a few mins. For gear, tailoring is the best ofc but you can use other tailors to make gear for you and the only money would be saving if you had tailoring yourself would be the cost of chaos orbs which are pretty cheap anyway compared to the amount you could make with alchemy. Also, alchemy is the easiest/cheapest prof to lvl up.
There aren't really any good rings from jewelcrafting at max lvl.