I'm playing as a frost and later frost fire mage, I was wondering what a good professions for leveling and pvp. I was thinking just doing regular money making professions, herbalism and skinning, but goblins excel in alchemy so I was wondering what professions I should go with

dust storm over here, i just heard WoW

The haste buff herbalism will give you is important. You can place this in a macro with your boss cooldowns. Alchemy is always a plus, you get potions, 2 hour flasks, the works. What isn't there to love? I would go with herbalism, alchemy as a caster. Although Alchemy by itself won't actually benefit you without the potions/flasks herbalism will. Hope this helped you make up your mind. I have herbalism on both my casting toons.

Also, tailoring has the most intellect from any profession. It is, however, a proc. Lightweave Embroidery gives 570 intellect for 15 seconds with a 20% proc rate on spellcast. It has a 50 second cooldown.

??????????????????

If you are going for PVP, Alchemy and Herbalism would be an alright choice.

Alchemy supplies various potions and flasks that are allowed to be used in Arenas and stuff like that, so it's best to go for this choice...

Herbalism only really grants a Haste buff, which is alright for dungeons should you need it... Herbalism also helps make Alchemy easier to level by supplying the mats yourself without having to spend a ton of gold on them.