I am planning on being a hold priest and I have already done the whole herbalist/alchemist on one of my characters and don't want to do that again so I was wondering what else would be a good pair of professions?

Jewelcrafting & Tailoring - The Jewelcrafting will require buying mats, but if you enjoy "playing" the auction house, this shouldn't be too bad. If you don't have money or make money via the auction house, you'll find Jewelcrafting and Mining a better combo.

Enchanting & Tailoring

Enchanting & Inscription

Enchanting & Tailoring

You really have a lot of possible combinations. My priest is jewelcrafting and mining, but I have considered switching mining to something with more raiding benefits. That would require a collecting character (thinking of making another druid that simply collects herbs and mines since the flight form helps with farming speed).

My priest is Holy Pve. And disc pvp. And is Tailoring/Mining. Like the person above said. You have many combinations.